Transition from configuring to active by itself once on launch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Große Besselmann <grosse@fzi.de>
stefanscherzinger
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Nice, thank you! That's better.
I left two hints about comments. I like a minimal verbosity in the launch files. Also, could you update the top-level readme? There are still lifecycle start instructions in the Getting started section.
Co-authored-by: Stefan Scherzinger <scherzin@fzi.de>
|
Small addition: @MGBla Could you also update the unconfigured state in this table? I would remove the first part of the sentence. |
Signed-off-by: Marvin Große Besselmann <grosse@fzi.de>
Signed-off-by: Marvin Große Besselmann <grosse@fzi.de>
stefanscherzinger
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the driver to directly start (with configuration and activation) on bootup. This way the manual CLI input is no longer required which makes it easier to use. I also changed from Node to LifecycleNode in the LaunchDescription