Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pydantic v2 #163

Closed
CasperWA opened this issue Oct 16, 2023 · 2 comments · Fixed by #182
Closed

Migrate to pydantic v2 #163

CasperWA opened this issue Oct 16, 2023 · 2 comments · Fixed by #182
Assignees
@CasperWA
Labels
enhancement New feature or request

Comments

@CasperWA
Copy link
Collaborator

Update the repository to support pydantic v2.

Only then can OTEAPI Core >= v0.6 be used.

The main dependency hindering a pydantic v2 upgrade is OPTIMADE Python tools (optimade).
@CasperWA CasperWA added the enhancement New feature or request label Oct 16, 2023
@CasperWA
Copy link
Collaborator Author

OPTIMADE Python tools has just merged in a PR to support pydantic v2: Materials-Consortia/optimade-python-tools#1745.
This means the migration can start to be implemented in this repository by temporarily depending on the repository's master branch.
Once v1.0.0 of OPTIMADE Python tools has been released, it should be used and the migration can be a proper part of this package as well.

@CasperWA CasperWA self-assigned this Oct 23, 2023
@CasperWA
Copy link
Collaborator Author

The missing dependency now is oteapi-dlite. To follow its update to support pydantic v2 see EMMC-ASBL/oteapi-dlite#187.

@CasperWA CasperWA mentioned this issue Nov 11, 2023
Merged
This was referenced Nov 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to pydantic v2 SINTEF/oteapi-optimade
1 participant
@CasperWA