Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noisy kriging example #527

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Add noisy kriging example #527

merged 8 commits into from
Mar 7, 2024

Conversation

Paul-Saves
Copy link
Contributor

No description provided.

relf
relf reviewed Mar 6, 2024
View reviewed changes
doc/_src_docs/surrogate_models/krg.rstx Outdated Show resolved Hide resolved
doc/_src_docs/surrogate_models/krg_Test_test_mixed_int_krg.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new picture is different. Is it normal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's not :(

smt/surrogate_models/tests/test_surrogate_model_examples.py Outdated Show resolved Hide resolved
@Paul-Saves Paul-Saves marked this pull request as draft March 7, 2024 08:38
@Paul-Saves Paul-Saves requested a review from relf March 7, 2024 12:56
@Paul-Saves Paul-Saves marked this pull request as ready for review March 7, 2024 12:56
relf
relf requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@relf relf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to commit _src_docs/surrogate_models/krg_Test_test_noisy_krg.png which is currently missing. Otherwise, once tests pass it is ok for me, the bug on mixed integer kriging will be addressed in a subsequent PR.

@relf relf changed the title enhance TNC and add contents in doc Add noisy kriging example Mar 7, 2024
@relf relf merged commit 9607ebc into SMTorg:master Mar 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relf relf relf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Paul-Saves @relf