Result of Benchmark Tests

Comment about the guts of CompositeTransformation: internally it performs matrix multiplication of the composed unitary transformations. The composite matrix is not supposed to be accessed by users, who should use the survival and transition probability functions prob_ee(t, E) etc. provided by the base class. For efficiency, the calculation of the transformation matrix is memoized so that it is not recalculated for all transition probabilities unless the input time and energy arguments change.

On this topic, the following checks should be completed:

• Unit test of the interface
• Checks that memoization works as intended
• Checks that ndarray arguments for input time and energy work

At first glance, this looks good to me; thanks! I would also suggest updating the FlavorTransformation.ipynb to add an example for this composite transformation.

The idea is a good one but the present implementation of the flavor transformations in SNEWPY means that there are only limited circumstances where you can string together flavor transformations. The neutrinos would have to decohere between the transformations being applied and the only flavor transformation we have in SNEWPY which occurs outside the supernova is neutrino decay.

I checked the math and it turns out chaining together SNEWPY's flavor transformations cannot be done even if the previously mentioned restriction that the neutrinos decohere between transformations is valid. Attached is a proof.
proof.pdf

Thanks for checking this and writing it up! If I understand correctly, there’s two different ways we could fix this:

1. If we switch to six-flavour oscillations (see Treat μ and τ flavours separately #99), we wouldn’t need the L and R matrices anymore
2. If we stick with four-flavour oscillations, we could calculate the self.De1, self.De2 etc. in the __init__ function (as we already do for many of the existing transformations) and then use those in the calculation to compose flavour transformations.

Either option should work. The second is the easiest and I know what to do. I haven't looked at how much of the code would have to change if we went to 6 flavors though it's something we said we'd do.