Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to Warren_2020 models on Zenodo. #202

Open
2 tasks
sybenzvi opened this issue Aug 3, 2022 · 1 comment
Open
2 tasks

Fix access to Warren_2020 models on Zenodo. #202

sybenzvi opened this issue Aug 3, 2022 · 1 comment
Assignees
Labels
bug Something isn't working ModelRegistry Connected to the registry of models

Comments

@sybenzvi
Copy link
Contributor

sybenzvi commented Aug 3, 2022

The model_registry_jan22 branch now supports downloading the Warren_2020 models from Zenodo, but we discovered that the untarred HDF5 files available on Zenodo do not cover all of the simulations from Warren et al. As a result, the Warren_2020 unit tests have been temporarily disabled.

It does appear that the three uploaded tarfiles stir_multimessenger_a1.23.tar, stir_multimessenger_a1.25.tar, and stir_multimessenger_a1.27.tar do contain the missing files. So we need to:

  • Update the Warren_2020 constructors in snewpy.models.ccsn and snewpy.models.loaders to use the tar files rather than the individual HDF5 files.
  • Reactivate the unit tests.
@sybenzvi sybenzvi added the bug Something isn't working label Aug 3, 2022
@JostMigenda JostMigenda added this to the v1.4 milestone Sep 15, 2022
@JostMigenda
Copy link
Member

For now, in #184 we have returned to downloading the Warren_2020 model files (individual .h5 files, not the .tar files) from GitHub. See discussion in there for some more problems we’ve encountered with unit tests and downloading tar files.

@Sheshuk Sheshuk added the ModelRegistry Connected to the registry of models label May 26, 2023
@JostMigenda JostMigenda removed this from the v1.4 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ModelRegistry Connected to the registry of models
Projects
None yet
Development

No branches or pull requests

4 participants