Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic replacement of placeholder statements when generating ddck files from the GUI #233

Closed
9 tasks done
martin-neugebauer opened this issue Jan 26, 2022 · 2 comments
Closed
9 tasks done

Comments

@martin-neugebauer
Copy link
Contributor

martin-neugebauer commented Jan 26, 2022

The newly introduced statements in the form of @type(portName, defaultName), e.g. @temp(hpCondIn, TPiHpCondIn), should be correctly replaced with the connection names from the GUI. This requires the completion of a number of subtasks:

@martin-neugebauer
Copy link
Contributor Author

@zuckerruebe Feel free to extend and adapt

@martin-neugebauer
Copy link
Contributor Author

martin-neugebauer commented Jan 28, 2022

@zuckerruebe The first task is fulfilled by #235, but some tests still have to be adapted for the changes I made. Maybe this is something that @PuaYongHao could do on Monday. We also need to deal with #234, a problem which was made worse by the changes I did, but I don't see a way around it. This means we might need some translator that translates diagrams of previous versions to the current one, such that we don't need to redo all diagrams by hand (this wouldn't be popular by many users, I guess.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants