Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better logic for writing index.html meta tags #6

Open
chucker opened this issue Nov 19, 2019 · 3 comments
Open

Need better logic for writing index.html meta tags #6

chucker opened this issue Nov 19, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@chucker
Copy link
Contributor

chucker commented Nov 19, 2019

My website has different paths (rather than different host names) depending on the build config, like:

I'm using ServiceWorkerBaseUrl and ManifestBaseUrl to set the base accordingly.

However, this only works once. Once the index.html contains the manifest and service worker URLs, MSBuild no longer touches it:

    Condition="'$(IndexLines.Contains($(ServiceWorkerRegisterFileName)))'=='false'"

This logic doesn't really work when switching between different URLs as described above.

Two possible approaches:

  • don't edit the index.html at all, but rather create an intermediary version
  • edit it, but improve the Condition such that the edited line can still be updated
@SQL-MisterMagoo SQL-MisterMagoo added the enhancement New feature or request label Nov 21, 2019
@SQL-MisterMagoo
Copy link
Owner

Thanks for finding this - I'll see what can be done.

@SQL-MisterMagoo
Copy link
Owner

I've not forgotten - just been busy!

@chucker
Copy link
Contributor Author

chucker commented Dec 18, 2019

It's fine! Me too, actually. Probably won't get back to my Blazor project until mid-January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants