Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Tileson has full C++20 support! #53

Closed
SSBMTonberry opened this issue Feb 18, 2022 · 3 comments · Fixed by #62
Closed

Make sure Tileson has full C++20 support! #53

SSBMTonberry opened this issue Feb 18, 2022 · 3 comments · Fixed by #62
Assignees
@SSBMTonberry
Labels
bug Something isn't working
Milestone
Version 1.4.0

Comments

@SSBMTonberry
Copy link
Owner

SSBMTonberry commented Feb 18, 2022 •
edited

It seems like there are problems when using C++20 with Tileson on Windows. Make sure Tileson builds OK when using C++20 and C++17 on all major compilers. That is MSVC, GCC and Clang
@SSBMTonberry SSBMTonberry added the bug Something isn't working label Feb 18, 2022
@SSBMTonberry SSBMTonberry added this to the Version 1.3.1 milestone Feb 18, 2022
@SSBMTonberry SSBMTonberry self-assigned this Feb 18, 2022
@SSBMTonberry SSBMTonberry modified the milestones: Version 1.3.1, Version 1.4.0 Feb 27, 2022
@ProfAndreaPollini
Copy link

Hi, I tried to fix the lib for c++20. I made a very dirty work, so it's not good for a PR, but it works for me :)

@SSBMTonberry
Copy link
Owner Author

@ProfAndreaPollini : Feel free to share your dirty fix here for other users to see until my official fix is implemented 🙂

This was referenced Apr 3, 2022
Closed
Merged
@SSBMTonberry SSBMTonberry linked a pull request Apr 11, 2022 that will close this issue
Changed to use generic_string so that it can build under c++ 20 #62
Merged
@SSBMTonberry
Copy link
Owner Author

@gamecoder-nz created a fix on this. I've verified that it works on Windows and Linux, but will wait until the 1.4.0 release before I verify on OSX. On a partly unrelated note: The CI doesn't seem to like C++20 very well...

@SSBMTonberry SSBMTonberry mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SSBMTonberry SSBMTonberry

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.4.0
Development

Successfully merging a pull request may close this issue.

Changed to use generic_string so that it can build under c++ 20
2 participants
@ProfAndreaPollini @SSBMTonberry