Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to rebuild amalgamated headers on OSX #82

Merged
merged 1 commit into from Dec 1, 2022
Merged

Add script to rebuild amalgamated headers on OSX #82

merged 1 commit into from Dec 1, 2022

Conversation

dmlary
Copy link
Contributor

@dmlary dmlary commented Nov 30, 2022

Use https://github.com/Viatorus/quom (python utility) to construct the amalgamated header on platforms the original amalgamate binary won't run.

fixes #80

Use https://github.com/Viatorus/quom (python utility) to construct the
amalgamated header on platforms the original amalgamate binary won't
run.

fixes #80
@SSBMTonberry
Copy link
Owner

I'll just do a quick test of this after work, but looks good 😄
Seems like the CI is not working properly right now, so don't mind those errors. I'll have to do a fix there.

@SSBMTonberry
Copy link
Owner

SSBMTonberry commented Dec 1, 2022

@dmlary : I've just tested this script on my Linux setup, just because there is no reason why it shouldn't work, and I think your solution is just great! Well done 😄

I started off with not having quom installed, and I got the very descriptive message:

This script depends on the quom utility to combine the header files:
    https://github.com/Viatorus/quom

Quom is a python 3.6 (or above) utility that can be installed via pip:
    pip install quom

Or on OSX with python3 from homebrew installed:
    pip3 install quom

Ensure that the quom utility is in your PATH when running this script:
    PATH="~/Library/Python/3.10/bin:$PATH" ./amalgamate_osx.sh

So I ran pip3 install quom as the instruction says, which installed quom, and then it worked just fine.

Approved! 🥳

@SSBMTonberry SSBMTonberry merged commit 275dc8f into SSBMTonberry:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests depend on amalgamated header, but amalgamate tool requires Linux or Windows; no source provided
2 participants