Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: centralize detection of window features #333

Open
alvarosabu opened this issue Nov 29, 2018 · 3 comments
Open

Feature Request: centralize detection of window features #333

alvarosabu opened this issue Nov 29, 2018 · 3 comments
Labels
feature good first issue This issue is good for a new vue developer! help wanted

Comments

@alvarosabu
Copy link

Is your feature request related to a problem?
I'm implementing a long Form with a carousel slides separate groups of inputs. I have an issue disabling the mouseDrag prop whenever the user focus on an imput and allowing it again onBlur.

It seems that this prop only configure the eventListeners on init, but doesn't change whenever the input does.

Describe the solution you'd like
MouseDrag & TouchDrag to be able to change on the go.

If any, describe the alternatives you've considered
I thought about disabling pointer-events: none; with css but then everything inside the form is useless.

Teachability, Documentation, Adoption, Migration Strategy
Well, developers will be able to change the prop according to events other thant the initialization of the component.

@quinnlangille
Copy link
Member

Hey @alvarosaburido, I was also thinking about this recently. We're currently working on refactoring the carousel and this could be a reasonable feature. Mouse and touch drag both depend on different available features in the window.

As you've mentioned, we only check these properties on init. I'd have to think about implementation, maybe we could wrap all of our checks in one method and save results to state. This would allow us to update on the go if need be. Is that along the lines of what you were thinking?

@alvarosabu
Copy link
Author

Hey, man @quinnlangille yeah, exactly what I meant. The next week I'm on vacation maybe I can give it a try in an MR meanwhile. If you are working on refactoring, let me know if I can contribute with it.

@quinnlangille
Copy link
Member

Hey @alvarosaburido totally didn't see your last notification - we're still planning the refactor internally, so it likely won't kick off for a while. However, if you find yourself implementing the feature we can just port over the logic if the refactor happens after.

In the meantime, I'll rename and properly tag this. Thanks for the feature request!

@quinnlangille quinnlangille added help wanted feature good first issue This issue is good for a new vue developer! labels Dec 7, 2018
@quinnlangille quinnlangille changed the title Change Detenction of mouseDrag & touchDrag Feature: centralize detection of window features Dec 7, 2018
@quinnlangille quinnlangille changed the title Feature: centralize detection of window features Feature Request: centralize detection of window features Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue This issue is good for a new vue developer! help wanted
Projects
None yet
Development

No branches or pull requests

2 participants