Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INI Parser should not expose its internal storage #1079

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

INI Parser should not expose its internal storage #1079

sssd-bot opened this issue May 2, 2020 · 0 comments
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/37

  • Created at 2009-05-14 14:55:16 by sgallagh
  • Closed as Fixed
  • Assigned to dpal

The INI Parser API should be opaque as to what its internal storage looks like. Instead of returning collection_items, it should be returning opaque ini_config_items (probably a typedef for collection_item, internally).

Furthermore, there should be a free_ini_config() function that acts as a wrapper around delete_collection.

This will give us more flexibility in the future if we decide to change the underlying data type from "collection" to something else.

Comments


Comment from dpal at 2009-07-15 00:06:04

The wrappers were created:
commit 09c4b07

After discussion we decided not to hide the "struct collection_item *" from the caller so this part won't be fixed.

fixedin: => 0.5.0
resolution: => fixed
status: new => closed


Comment from dpal at 2009-07-15 00:06:04

The wrappers were created:
commit 09c4b07

After discussion we decided not to hide the "struct collection_item *" from the caller so this part won't be fixed.

fixedin: => 0.5.0
resolution: => fixed
status: new => closed


Comment from dpal at 2009-07-15 00:06:04

The wrappers were created:
commit 09c4b07

After discussion we decided not to hide the "struct collection_item *" from the caller so this part won't be fixed.

fixedin: => 0.5.0
resolution: => fixed
status: new => closed


Comment from dpal at 2012-01-19 02:10:02

Fields changed

rhbz: => 0


Comment from dpal at 2012-01-19 02:10:02

Fields changed

rhbz: => 0


Comment from dpal at 2012-01-19 02:10:02

Fields changed

rhbz: => 0


Comment from sgallagh at 2017-02-24 14:29:15

Metadata Update from @sgallagh:

  • Issue assigned to dpal

Comment from sgallagh at 2017-03-01 16:08:01

Metadata Update from @sgallagh:

  • Issue set to the milestone: void
@sssd-bot sssd-bot added the Closed: Fixed Issue was closed as fixed. label May 2, 2020
@sssd-bot sssd-bot closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

No branches or pull requests

1 participant