Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbosity of collection unit tests must be lowered #1328

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

Verbosity of collection unit tests must be lowered #1328

sssd-bot opened this issue May 2, 2020 · 0 comments
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/286

  • Created at 2009-11-20 19:33:57 by sgallagh
  • Closed as Fixed
  • Assigned to dpal

The verbosity level of the collection tests is far too high to be useful. By default, it should print only errors.

Bonus points for allowing full verbosity by an environment variable.

Comments


Comment from dpal at 2009-11-20 19:43:21

Why it is critical?


Comment from sgallagh at 2009-11-20 19:46:09

The unit tests are completely worthless right now because if they fail, locating the offending message is nearly impossible. It's marked critical only because that just happened to be the priority one above "major" (which is the default).


Comment from dpal at 2009-11-20 20:13:53

I do not think it is a priority at all because if it fail the error will be right at the end of the output so there is no problem in finding it. The things that flew by are not important if you just care about the errors.

I will fix it later and make it more readble at the same time to do other re-factoring for collection.

milestone: SSSD 1.0 => SSSD Deferred
priority: critical => minor


Comment from dpal at 2009-12-17 05:30:42

Patches to do this are already either committed or on the list to review.

proposed: => 1.1


Comment from sgallagh at 2010-01-07 16:40:27

Fields changed

milestone: SSSD Deferred => SSSD 1.1


Comment from dpal at 2010-02-09 15:25:53

Changeset 3c401be

fixedin: => 1.1.0
resolution: => fixed
status: new => closed


Comment from dpal at 2012-01-19 02:37:39

Fields changed

rhbz: => 0


Comment from sgallagh at 2017-02-24 14:28:34

Metadata Update from @sgallagh:

  • Issue assigned to dpal
  • Issue set to the milestone: SSSD 1.1
@sssd-bot sssd-bot added the Closed: Fixed Issue was closed as fixed. label May 2, 2020
@sssd-bot sssd-bot closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

No branches or pull requests

1 participant