Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NULL dereference in sdap_child_helpers #1551

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

NULL dereference in sdap_child_helpers #1551

sssd-bot opened this issue May 2, 2020 · 0 comments

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/509

  • Created at 2010-06-03 02:22:38 by sgallagh
  • Closed as Duplicate
  • Assigned to nobody

From Coverity:

Comparing "realm_str" to null implies that "realm_str" might be null.
  175    if (realm_str) {
  176        SAFEALIGN_SET_UINT32(&buf->data[rp], strlen(realm_str), &rp);
  177        safealign_memcpy(&buf->data[rp], realm_str, strlen(realm_str), &rp);
  178    } else {
  179        SAFEALIGN_SET_UINT32(&buf->data[rp], 0, &rp);
  180    }

We need to fix this. We're definitely dereferencing NULL if the realm_str doesn't exist.

Comments


Comment from sgallagh at 2010-06-04 13:51:53

Apparently, I opened this twice. See Ticket #508

resolution: => duplicate
status: new => closed


Comment from dpal at 2012-01-19 02:12:40

Fields changed

rhbz: => 0


Comment from simo at 2012-03-08 15:25:44

Fields changed

milestone: NEEDS_TRIAGE => void


Comment from sgallagh at 2017-02-24 14:59:09

Metadata Update from @sgallagh:

  • Issue set to the milestone: void
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant