Unchecked call to hash_delete() in proxy_child_destructor()

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/534

• Created at 2010-06-04 13:55:56 by sgallagh
• Closed as Fixed
• Assigned to sgallagh

---

From Coverity:

Calling function "hash_delete" without checking return value.
No check of the return value of "hash_delete(child_ctx->auth_ctx->request_table, &key)".
  198    hash_delete(child_ctx->auth_ctx->request_table, &key);
  199    return 0;
  200}

We should check this and report an error if we get anything besides HASH_SUCCESS or HASH_ERROR_KEY_NOT_FOUND here.

Comments

---

Comment from sgallagh at 2010-06-08 15:34:14

Fields changed

owner: somebody => sgallagh
status: new => assigned

---

Comment from sgallagh at 2010-06-08 17:01:12

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1

---

Comment from sgallagh at 2010-06-09 15:00:36

Fields changed

keywords: => coverity

---

Comment from sgallagh at 2010-06-10 16:35:25

Fixed by 92dc627

resolution: => fixed
status: assigned => closed

---

Comment from sgallagh at 2010-06-10 16:38:40

Fields changed

fixedin: => 1.2.1

---

Comment from dpal at 2012-01-19 02:48:54

Fields changed

rhbz: => 0

---

Comment from sgallagh at 2017-02-24 14:55:08

Metadata Update from @sgallagh:

• Issue assigned to sgallagh
• Issue set to the milestone: SSSD 1.2.1