[path_utils] dead storage in path_utils.c

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/575

• Created at 2010-07-28 11:30:35 by jhrozek
• Closed at 2017-03-01 17:30:30 as None
• Assigned to dpal

---

Two cases of dead storage in path_utils.c:

- in `directory_list()`, the value of `prune` in unconditionally overwritten after the first assignment:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-NCECM2.html#EndPath

- in `is_ancestor_path()`, the value of result is set in all the branches which also return as well as when no branch is selected. Maybe it would be nicer to rewrite the code with if..else if..else..
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-gp1oRt.html#EndPath

- in `split_path()`, although the value stored to `component_len` is used in the enclosing expression, the value is never actually read from `component_len` after that point:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-rpgeQB.html#EndPath

Assigning to dpal as per his request.

Comments

---

Comment from jhrozek at 2010-07-28 16:12:13

Fields changed

priority: major => minor

---

Comment from jhrozek at 2010-07-28 16:12:13

Fields changed

priority: major => minor

---

Comment from jhrozek at 2010-07-28 16:12:13

Fields changed

priority: major => minor

---

Comment from dpal at 2010-07-30 00:14:24

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

---

Comment from dpal at 2010-07-30 00:14:24

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

---

Comment from dpal at 2010-07-30 00:14:24

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0

---

Comment from dpal at 2012-01-19 03:25:42

Fields changed

rhbz: => 0

---

Comment from dpal at 2012-01-19 03:25:42

Fields changed

rhbz: => 0

---

Comment from dpal at 2012-01-19 03:25:42

Fields changed

rhbz: => 0

---

Comment from dpal at 2012-09-26 22:13:05

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

---

Comment from dpal at 2012-09-26 22:13:05

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

---

Comment from dpal at 2012-09-26 22:13:05

Fields changed

blockedby: =>
blocking: =>
coverity: =>
feature_milestone: =>
milestone: Tools Backlog => Tools 2.0
patch: => 0

---

Comment from dpal at 2012-12-23 22:20:32

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

---

Comment from dpal at 2012-12-23 22:20:32

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

---

Comment from dpal at 2012-12-23 22:20:32

Fields changed

design: =>
design_review: => 0
fedora_test_page: =>
selected: =>
testsupdated: 0 => 1

---

Comment from dpal at 2012-12-23 22:20:53

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

---

Comment from dpal at 2012-12-23 22:20:53

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

---

Comment from dpal at 2012-12-23 22:20:53

Fields changed

patch: 0 => 1
testsupdated: 1 => 0

---

Comment from jhrozek at 2017-02-24 14:23:21

Metadata Update from @jhrozek:

• Issue assigned to dpal
• Issue set to the milestone: Tools 2.0

---

Comment from lslebodn at 2017-03-01 17:30:18

Ticket is moved out of sssd issue tracker.

https://pagure.io/SSSD/ding-libs/issue/575

---

Comment from lslebodn at 2017-03-01 17:30:25

Metadata Update from @lslebodn:

• Custom field component reset
• Custom field design_review reset
• Custom field patch adjusted to on (was: 1)
• Custom field testsupdated reset
• Custom field type reset
• Custom field version reset
• Issue close_status updated to: None

---

Comment from lslebodn at 2017-03-01 17:30:36

Metadata Update from @lslebodn:

• Custom field design_review reset
• Custom field patch reset
• Custom field testsupdated reset
• Issue status updated to: Closed (was: Open)