Issues with write_krb5info_file()'s use of "ret"

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/631

• Created at 2010-09-23 15:43:39 by sgallagh
• Closed as Fixed
• Assigned to sbose

---

There are two issues here.

1. Uninitialized return of {{{ret}}}

   if (written != server_len) {
       DEBUG(1, ("Write error, wrote [%d] bytes, expected [%d]\n",
                  written, server_len));
       goto done;
   }
   

2. Inconsistent use of {{{ret}}}. Some places we return an errno_t value (which is correct, by the function's return type), and other times we return errors directly from functions like {{{write()}}} and {{{fchmod()}}} which do not use errno_t return values.

Comments

---

Comment from jhrozek at 2010-09-24 14:06:45

Fields changed

owner: jhrozek => sbose

---

Comment from dpal at 2010-09-28 14:57:24

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.4.0

---

Comment from sgallagh at 2010-09-28 19:38:24

Fixed by 5d395f5

fixedin: => 1.4.0
resolution: => fixed
status: new => closed

---

Comment from sgallagh at 2010-09-28 19:38:52

Sorry, correction.
Fixed by f7fa22d

---

Comment from dpal at 2012-01-19 02:55:04

Fields changed

rhbz: => 0

---

Comment from sgallagh at 2017-02-24 14:50:00

Metadata Update from @sgallagh:

• Issue assigned to sbose
• Issue set to the milestone: SSSD 1.4.0