Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review our use of strtol() when converting to uid_t or gid_t #1692

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

review our use of strtol() when converting to uid_t or gid_t #1692

sssd-bot opened this issue May 2, 2020 · 0 comments
Assignees
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/650

  • Created at 2010-10-15 13:37:31 by jhrozek
  • Closed as Fixed
  • Assigned to jhrozek

As Stephen mentioned during a patch review, strtol() may not be safe for converting to uid_t and gid_t since uid_t and gid_t are a uint32_t, which on 32-bit platforms may require unsigned long.

Comments


Comment from jhrozek at 2010-10-15 13:37:50

Fields changed

owner: somebody => jhrozek


Comment from jhrozek at 2010-10-15 13:55:21

Fields changed

summary: review our use of strtol() when converting to uid_t or git_t => review our use of strtol() when converting to uid_t or gid_t


Comment from sgallagh at 2010-10-18 19:51:18

Fields changed

fixedin: => 1.4.0
milestone: NEEDS_TRIAGE => SSSD 1.4.0
resolution: => fixed
status: new => closed
tests: 0 => 1


Comment from dpal at 2012-01-19 02:55:32

Fields changed

rhbz: => 0


Comment from jhrozek at 2017-02-24 14:57:54

Metadata Update from @jhrozek:

  • Issue assigned to jhrozek
  • Issue set to the milestone: SSSD 1.4.0
@sssd-bot sssd-bot added the Closed: Fixed Issue was closed as fixed. label May 2, 2020
@sssd-bot sssd-bot closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

No branches or pull requests

2 participants