Memory leak in the comment management

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/736

• Created at 2010-12-17 01:21:08 by dpal
• Closed as Fixed
• Assigned to nobody

---

In ini/ini_comment.c

The check is incorrect.

         case INI_COMMENT_MODE_INSERT:
  288
  289        TRACE_INFO_STRING("Insert mode", "");
  290        len = ref_array_len(ic->ra);
  291        if (idx > len) {
  292            /* Fill in empty lines */
  293            for (i = 0; i < (idx-len); i++) {
Calling allocation function "calloc".
Assigning: "empty" = storage returned from "calloc(1UL, 1UL)".
  294                empty = strdup("");
At conditional (1): "empty" taking the true branch.
  295                if (empty) {
  296                    TRACE_ERROR_NUMBER("Memory problem", ENOMEM);
Variable "empty" going out of scope leaks the storage it points to.
  297                    return ENOMEM;
  298                }
  299                error = ref_array_append(ic->ra, (void *)&empty);
  300                if (error) {
  301                    TRACE_ERROR_NUMBER("Append problem", error);
  302                    free(empty);
  303                    return error;
  304                }
  305                error = ref_array_append(ic->ra_len, (void *)&input_len);
  306                if (error) {
  307                    TRACE_ERROR_NUMBER("Error adding lenghts", error);
  308                    free(empty);
  309                    return error;
  310                }

Comments

---

Comment from dpal at 2010-12-17 01:21:33

Fields changed

summary: Memory leak in the comment managment => Memory leak in the comment management

---

Comment from dpal at 2010-12-17 01:21:33

Fields changed

summary: Memory leak in the comment managment => Memory leak in the comment management

---

Comment from dpal at 2010-12-17 01:21:33

Fields changed

summary: Memory leak in the comment managment => Memory leak in the comment management

---

Comment from sgallagh at 2010-12-17 14:27:33

Fields changed

coverity: => 10041
keywords: => Coverity

---

Comment from sgallagh at 2010-12-17 14:27:33

Fields changed

coverity: => 10041
keywords: => Coverity

---

Comment from sgallagh at 2010-12-17 14:27:33

Fields changed

coverity: => 10041
keywords: => Coverity

---

Comment from dpal at 2010-12-24 05:15:46

This code is fixed on master. It is Ok to ignore it on the release branch since this code path is not executed yet.

---

Comment from dpal at 2010-12-24 05:15:46

This code is fixed on master. It is Ok to ignore it on the release branch since this code path is not executed yet.

---

Comment from dpal at 2010-12-24 05:15:46

This code is fixed on master. It is Ok to ignore it on the release branch since this code path is not executed yet.

---

Comment from dpal at 2010-12-24 05:16:06

Fields changed

resolution: => fixed
status: new => closed

---

Comment from dpal at 2010-12-24 05:16:06

Fields changed

resolution: => fixed
status: new => closed

---

Comment from dpal at 2010-12-24 05:16:06

Fields changed

resolution: => fixed
status: new => closed

---

Comment from dpal at 2012-01-19 03:26:12

Fields changed

rhbz: => 0

---

Comment from dpal at 2012-01-19 03:26:12

Fields changed

rhbz: => 0

---

Comment from dpal at 2012-01-19 03:26:12

Fields changed

rhbz: => 0

---

Comment from dpal at 2017-02-24 15:08:10

Metadata Update from @dpal:

• Issue set to the milestone: Tools Backlog