sss_obfuscate/python config parser modifies config file too much

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/763

• Created at 2011-01-05 12:43:38 by sbose
• Closed as Fixed
• Assigned to jzeleny
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=785879

---

When calling sss_obfuscate with the following simplified config file:

; comment
[sssd]
config_file_version = 2

[domain/ABC]
id_provider = ldap

; trailing comment

to following is returned:

# comment
[sssd]
config_file_version = 2

domains = 
[domain/ABC]
cache_credentials = False
ldap_default_authtok_type = obfuscated_password
id_provider = ldap
ldap_id_use_start_tls = False
debug_level = 0
ldap_schema = rfc2307
ldap_default_authtok = AAAQAE0p7C2dwEkkvfhfsYO3h7E5avTltddh8+1sPi61Ff1tyHWJll0xoMaIrLjlz5WQ/k44UA1lns9I8K+hxYJIvJQAAQIDAAA=

As sss_obfuscate changes the config file more than just adding ldap_default_authtok_type and ldap_default_authtok it should save a copy of the original file.

I see the following issues with the additional changes:
- trailing comments are remove
- according to sssd.conf(5) '#' and ';' are valid signs for comments, so it would be nice if both are preserved respectively
- adding default values for options which where not in the original file might lead to a config file less readable
- an explicit 'debug_level = 0' overwrites the debug level given at the sssd command line, so it shouldn't be written to the new config file

Comments

---

Comment from sgallagh at 2011-01-05 12:47:44

I opened ticket #764 to address the debug_level issue. The command-line should always override the option set in sssd.conf.

---

Comment from dpal at 2011-01-20 14:48:29

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.6.0
upgrade: => 0

---

Comment from dpal at 2011-02-03 15:31:26

Fields changed

priority: major => trivial

---

Comment from dpal at 2011-02-07 15:54:10

Fields changed

owner: somebody => jzeleny

---

Comment from jzeleny at 2011-04-01 16:47:08

Fields changed

status: new => assigned

---

Comment from sgallagh at 2011-05-02 21:03:17

Fixed by 0e5879c

patch: => 0
resolution: => fixed
status: assigned => closed

---

Comment from sgallagh at 2012-01-30 21:17:52

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=785879

rhbz: => [https://bugzilla.redhat.com/show_bug.cgi?id=785879 785879]

---

Comment from sbose at 2017-02-24 15:07:09

Metadata Update from @sbose:

• Issue assigned to jzeleny
• Issue set to the milestone: SSSD 1.6.0