You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This came up during patch review of the autofs patches. It's not clear whether this enhancement can make 1.8 beta, so I'm filing it as a ticket.
Stephen said:
Why don't we just store the result data in the "struct automtent" when we complete the _sss_setautomntent() routine? Granted, we'd be carrying around
more memory in autofs, but it would be accessible quite a bit faster than going back and forth to the responder for multiple _sss_getautomntbyname_r()
calls. At the very minimum, it would be better to replicate what we're
doing in the NSS passwd client, where we get SSS_NSS_MAX_ENTRIES at a
time. I can see this being a bottleneck for a system looking up user home
directories for thousands of users.
Additional comment about this. It's not sufficient to have the
endautomntent() value not go to the responder. If the responder is
allocating memory and maintaining a view of the data for this request
series, we need to be able to tell it to release it when we're done.
(The responder will also need to implement a timer event to free memory
after a certain amount of time, so we don't have a memory leak problem
if the calling function doesn't invoke endautomntent())
Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1166
This came up during patch review of the autofs patches. It's not clear whether this enhancement can make 1.8 beta, so I'm filing it as a ticket.
Stephen said:
Why don't we just store the result data in the "struct automtent" when we complete the _sss_setautomntent() routine? Granted, we'd be carrying around
more memory in autofs, but it would be accessible quite a bit faster than going back and forth to the responder for multiple _sss_getautomntbyname_r()
calls. At the very minimum, it would be better to replicate what we're
doing in the NSS passwd client, where we get SSS_NSS_MAX_ENTRIES at a
time. I can see this being a bottleneck for a system looking up user home
directories for thousands of users.
Additional comment about this. It's not sufficient to have the
endautomntent() value not go to the responder. If the responder is
allocating memory and maintaining a view of the data for this request
series, we need to be able to tell it to release it when we're done.
(The responder will also need to implement a timer event to free memory
after a certain amount of time, so we don't have a memory leak problem
if the calling function doesn't invoke endautomntent())
Comments
Comment from dpal at 2012-02-09 16:01:18
Fields changed
milestone: NEEDS_TRIAGE => SSSD AutoFS cleanup
Comment from jhrozek at 2012-02-09 20:11:56
Fields changed
owner: somebody => jhrozek
Comment from dpal at 2012-02-10 21:34:38
Fields changed
rhbz: => 0
Comment from jhrozek at 2012-02-23 18:24:05
Fields changed
status: new => assigned
Comment from jhrozek at 2012-02-27 13:40:26
Fields changed
patch: 0 => 1
Comment from jhrozek at 2012-02-27 19:20:04
Fixed in 6f66af7
Comment from sgallagh at 2012-02-28 18:34:35
Fields changed
resolution: => fixed
status: assigned => closed
Comment from jhrozek at 2017-02-24 14:29:50
Metadata Update from @jhrozek:
The text was updated successfully, but these errors were encountered: