pam_sss requires SELinux #2250

sssd-bot · 2020-05-02T12:30:15Z

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1208

Created at 2012-02-23 06:18:01 by ejona
Closed as Fixed
Assigned to sgallagh

I just tried to build the 1.8.0beta3 on Arch Linux. When compiling, I got the following error:

src/sss_client/pam_sss.c:44:29: fatal error: selinux/selinux.h: No such file or directory

I do not have SELinux installed and thus selinux.h is correctly not found. I took a look at pam_sss and there are no conditionals around the selinux.h include and some of its symbols' usage. Is it now a requirement to have the SELinux installed? I compiled 1.6 and 1.7 without issue.

Comments

Comment from simo at 2012-02-23 07:26:24

attachment
0001-pam_sss-keep-selinux-optional.patch

Comment from simo at 2012-02-23 07:26:49

No Selinux is not required and should be optional.

Can you try the attached patch ?
I tested it by defining HAVE_SELINUX to 0 in my config.h file.

Comment from sgallagh at 2012-02-23 14:35:39

Version 2 - Make SELinux optional
0001-pam_sss-keep-selinux-optional.2.patch

Comment from sgallagh at 2012-02-23 14:37:27

The original patch was incomplete. The linker was still trying to pull in -lselinux.

This new version correctly makes the linker optional, as well as adding another ifdef around some variables in {{{send_and_recieve()}}} that are not used if SELinux is not in play (to avoid compiler warnings).

owner: somebody => sgallagh
patch: 0 => 1
status: new => assigned

Comment from sgallagh at 2012-02-23 14:40:15

Making this a 1.8.0 blocker as it will prevent non-SELinux distributions from building SSSD.

milestone: NEEDS_TRIAGE => SSSD 1.8.0 (LTM)
priority: major => blocker

Comment from sgallagh at 2012-02-24 03:03:03

Fixed by:
- 8d821f0 (master)
- 1380fad (sssd-1-8)

resolution: => fixed
status: assigned => closed

Comment from ejona at 2012-02-25 16:58:54

I just built from master and sssd-1-8, so your fix works for me.

Thanks for the speedy resolution. I would have tested a bit sooner, but I failed to realize I didn't have email notifications enabled.

Comment from dpal at 2012-03-03 04:53:33

Fields changed