sssd components mishandles sighup for helper processes #3720

sssd-bot · 2020-05-02T13:15:09Z

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2679

Created at 2015-06-16 15:06:02 by jhrozek
Closed at 2018-03-06 10:12:06 as duplicate
Assigned to mzidek
Associated bugzillas
- https://bugzilla.redhat.com/show_bug.cgi?id=1232303

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 6): Bug 1232303

Description of problem:
This BZ is related to #886038

sssd doesn't properly close fds from helper processes like krb5_child:

# ls /proc/*/fd -l| grep deleted
l-wx------. 1 root root 64 Jun  3 10:13 18 ->
/var/log/sssd/krb5_child.log-20150512 (deleted)

ssd debug_log_file is opened with open_debug_file_ex(..., bool want_cloexec):

[...]

(want_cloexec) {
         flags = fcntl(debug_fd, F_GETFD, 0);
         (void) fcntl(debug_fd, F_SETFD, flags | FD_CLOEXEC);
     }

(from util/debug.c)

This is not the case for LDAP_CHILD_LOG_FILE and KRB5_CHILD_LOG_FILE:

$ grep -iR CHILD_LOG_FILE providers/
providers/krb5/krb5_init_shared.c:        ret =
open_debug_file_ex(KRB5_CHILD_LOG_FILE, &debug_filep, false);
providers/ldap/sdap_child_helpers.c:        ret =
open_debug_file_ex(LDAP_CHILD_LOG_FILE, &debug_filep, false);


Version-Release number of selected component (if applicable):
sssd-1.11.6-30.el6_6.3.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comments

Comment from jhrozek at 2015-06-16 18:29:07

Fields changed

blockedby: =>
blocking: =>
changelog: =>
coverity: =>
design: =>
design_review: => 0
feature_milestone: =>
fedora_test_page: =>
mark: no => 0
owner: somebody => mzidek
review: True => 0
selected: =>
testsupdated: => 0

Comment from jhrozek at 2015-06-18 16:09:54

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.13 beta

Comment from jhrozek at 2015-08-05 13:19:54

Fields changed

priority: major => minor

Comment from jhrozek at 2015-08-20 18:13:18

Fields changed

milestone: SSSD 1.13.1 => SSSD 1.13.2

Comment from jhrozek at 2015-09-17 16:16:17

Fields changed

milestone: SSSD 1.13.2 => SSSD 1.13.3