ID mapping - bug in computing max id for slice range

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2922

• Created at 2016-01-13 14:43:22 by preichl
• Closed as Fixed
• Assigned to preichl
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1298629

---

There seems to be a bug in the way we assign ranges for domain when we algorithmically perform id mapping.

In sss_idmap_calculate_range() we compute the upper limit for ids max as being 'min + range' which means that actual range of ids is:

max - min + 1 = min + range - min + 1 = range + 1

And this differs from range by 1.

We should be even be able to see some mapping issue with secondary ranges. The last POSIX ID from a range and the first POSIX ID from the next range should return the same SID/RID.

In the IPA code there is 'range.max = r->base_id + r->id_range_size -1;' We should amend code to the same.

Comments

---

Comment from lslebodn at 2016-01-13 18:34:31

If there's seems to be a bug could you write unit test which will fail? TDD way.

---

Comment from jhrozek at 2016-01-14 16:36:42

Fields changed

rhbz: => [https://bugzilla.redhat.com/show_bug.cgi?id=1298629 1298629]

---

Comment from jhrozek at 2016-01-14 16:48:40

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.13.4
priority: major => critical

---

Comment from lslebodn at 2016-01-20 18:18:26

master:

• 7db89d4

sssd-1-13:

• 645933b

---

Comment from lslebodn at 2016-01-20 18:22:31

There is a missing unit test for this bug.
We needn't open new bug and it can be tracked here.

---

Comment from lslebodn at 2016-02-03 17:19:11

Man page change:

master:

• d9de4b2

sssd-1-13:

• c2fa17e

---

Comment from preichl at 2016-02-04 10:59:20

Fields changed

owner: somebody => preichl
status: new => assigned

---

Comment from preichl at 2016-02-10 15:07:24

Fields changed

patch: 0 => 1

---

Comment from lslebodn at 2016-02-15 10:13:21

Unit test

master:

• 9d17f43

sssd-1-13:

• 8c1f3b2

resolution: => fixed
status: assigned => closed

---

Comment from preichl at 2017-02-24 14:44:11

Metadata Update from @preichl:

• Issue assigned to preichl
• Issue set to the milestone: SSSD 1.13.4