Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build the local provider conditionally #4337

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

Only build the local provider conditionally #4337

sssd-bot opened this issue May 2, 2020 · 0 comments
Labels
Closed: Fixed Issue was closed as fixed.

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3304

  • Created at 2017-02-07 12:38:31 by pbrezina
  • Closed at 2018-08-13 18:34:16 as Fixed
  • Assigned to fidencio

We have refactored data provider API and almost finished conversion of responders to cache_req code. I think this gives us a good chance to finally create a dummy local provider process to get rid of all special cases in responders.

It would simplify future maintenance and helps us avoid local provider issues since it is not really used in real environment we tend to often forget about it.

Creating such provider is trivial.

Comments


Comment from jhrozek at 2017-02-07 13:04:37

When the files provider is merged, don't we want to just remove the local provider?


Comment from pbrezina at 2017-02-07 13:10:37

That would be even better. I thought you don't want to go this way.


Comment from jhrozek at 2017-02-10 10:20:09

As discussed yesterday, the current plan is to deprecate the local provider first and remove it eventually if nobody complains.

So the current scope of this ticket is to add a configure-time flag that would be disabled by default and must be enabled for the local provider to be built.

milestone: NEEDS_TRIAGE => SSSD 1.15.1
summary: create dummy local provider => Only build the local provider conditionally


Comment from pbrezina at 2017-02-24 14:33:08

Metadata Update from @pbrezina:

  • Issue set to the milestone: SSSD 1.15.1

Comment from jhrozek at 2017-03-03 11:46:02

Since we are releasing 1.15.1 today, I'm moving all unfinished tickets from 1.15.1 to 1.15.2


Comment from jhrozek at 2017-03-03 11:46:07

Metadata Update from @jhrozek:

  • Custom field design_review reset
  • Custom field mark reset
  • Custom field patch reset
  • Custom field review reset
  • Custom field sensitive reset
  • Custom field testsupdated reset
  • Issue close_status updated to: None

Comment from jhrozek at 2017-03-03 11:48:07

Metadata Update from @jhrozek:

  • Custom field design_review reset
  • Custom field mark reset
  • Custom field patch reset
  • Custom field review reset
  • Custom field sensitive reset
  • Custom field testsupdated reset
  • Issue set to the milestone: SSSD 1.15.2 (was: SSSD 1.15.1)

Comment from jhrozek at 2017-03-03 14:08:10

Metadata Update from @jhrozek:

  • Custom field design_review reset
  • Custom field mark reset
  • Custom field patch reset
  • Custom field review reset
  • Custom field sensitive reset
  • Custom field testsupdated reset
  • Issue set to the milestone: SSSD 1.15.3 (was: SSSD 1.15.2)

Comment from jhrozek at 2017-03-15 11:26:44

Metadata Update from @jhrozek:

  • Custom field design_review reset
  • Custom field mark reset
  • Custom field patch reset
  • Custom field review reset
  • Custom field sensitive reset
  • Custom field testsupdated reset
  • Issue set to the milestone: SSSD 1.15.4 (was: SSSD 1.15.3)

Comment from jhrozek at 2017-08-18 16:54:20

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue tagged with: cleanup-two-point-oh

Comment from jhrozek at 2017-08-23 17:45:10

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue untagged with: cleanup-two-point-oh
  • Issue set to the milestone: SSSD 2.0 (was: SSSD 1.15.4)

Comment from jhrozek at 2017-09-14 09:01:31

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue tagged with: breaks compatibility

Comment from jhrozek at 2018-03-22 14:07:46

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue priority set to: blocker (was: major)

Comment from fidencio at 2018-06-21 15:33:00

Metadata Update from @fidencio:

  • Issue assigned to fidencio

Comment from fidencio at 2018-08-07 10:13:43

Metadata Update from @fidencio:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue tagged with: PR

Comment from jhrozek at 2018-08-13 18:34:06


Comment from jhrozek at 2018-08-13 18:34:08

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)

Comment from jhrozek at 2018-08-13 18:34:18

Metadata Update from @jhrozek:

  • Custom field design_review reset (from false)
  • Custom field mark reset (from false)
  • Custom field patch reset (from false)
  • Custom field review reset (from false)
  • Custom field sensitive reset (from false)
  • Custom field testsupdated reset (from false)
  • Issue close_status updated to: Fixed
  • Issue status updated to: Closed (was: Open)
@sssd-bot sssd-bot added Breaks compatibility Closed: Fixed Issue was closed as fixed. labels May 2, 2020
@sssd-bot sssd-bot closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed: Fixed Issue was closed as fixed.
Projects
None yet
Development

No branches or pull requests

1 participant