Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python module configures services line in random order, breaking idempotency #4357

Closed
sssd-bot opened this issue May 2, 2020 · 0 comments
Closed

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3325

  • Created at 2017-03-08 00:38:07 by tibbs
  • Closed at 2020-03-24 14:27:43 as wontfix
  • Assigned to nobody

While trying to figure out why my configuration management system kept reporting that sssd.conf would change every time authconfig is run even though its arguments don't change, I realized that python3-sssdconfig will randomize the order of the "services" item in the "[sssd]" section.

Idempotency is important for configuration management systems like ansible; running a command twice should give exactly the same output as running it once. I can understand that it might not be reasonable to rewrite the items back in the original order, but the order chosen should at least be stable. I suspect that sticking "sorted()" in the right place would be quite sufficient.

Comments


Comment from tibbs at 2017-03-08 00:52:38

I guess any fix would have to go into IPAChangeConf.merge() or .dump() in ipachangeconf.py, but that code is somewhat complicated.


Comment from jhrozek at 2017-03-15 09:55:53

Stephen said he'd hack on this but I'm not sure exactly when he plans on doing this, so for now I'm adding this to the future milestone.


Comment from jhrozek at 2017-03-15 09:56:05

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD Future releases (no date set yet)

Comment from jhrozek at 2017-03-15 09:56:06

Stephen said he'd hack on this but I'm not sure exactly when he plans on doing this, so for now I'm adding this to the future milestone.


Comment from thalman at 2020-03-11 14:14:40

Metadata Update from @thalman:

  • Issue tagged with: Patch is welcome

Comment from pbrezina at 2020-03-24 14:27:42

Thank you for taking time to submit this request for SSSD. Unfortunately this issue was not given priority and the team lacks the capacity to work on it at this time.

Given that we are unable to fulfill this request I am closing the issue as wontfix.

If the issue still persist on recent SSSD you can request re-consideration of this decision by reopening this issue. Please provide additional technical details about its importance to you.

Thank you for understanding.


Comment from pbrezina at 2020-03-24 14:27:44

Metadata Update from @pbrezina:

  • Issue close_status updated to: wontfix
  • Issue status updated to: Closed (was: Open)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant