Use-after free if more sudo requests run and one of them fails, causing a fail-over to a next server

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3562

• Created at 2017-10-31 22:14:49 by jhrozek
• Closed at 2017-11-10 14:28:30 as Fixed
• Assigned to pbrezina
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1498734

---

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 1498734

Please note that this Bug is private and may not be accessible as it contains confidential Red Hat customer information.

We used to remember id_ctx->srv_opts in sudo request to switch
the latest usn values. This works fine most of the time but it may cause
a crash.

If we have two concurrent sudo refresh and one of these fails, it causes
failover to try the next server and possibly replacing the old srv_opts
with new one and it causes an access after free in the other refresh.

Comments

---

Comment from jhrozek at 2017-10-31 22:14:50

Metadata Update from @jhrozek:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1498734

---

Comment from jhrozek at 2017-10-31 22:20:12

PR: #429

---

Comment from jhrozek at 2017-10-31 22:20:13

Metadata Update from @jhrozek:

• Issue assigned to pbrezina
• Issue set to the milestone: None
• Issue tagged with: PR, bug

---

Comment from jhrozek at 2017-10-31 22:20:40

The only question before triage is if this affects also other branches, i.e. if we should apply the patch to sssd-1-13 as well.

---

Comment from lslebodn at 2017-10-31 23:13:20

master:

• 2ee201d

sssd-1-14:

• 1154c9e

Version for 1.13 could be easily done with cherry-pixk. There is just trivial conflict due to fq names refactoring sdap_sudo_qualify_names

---

Comment from jhrozek at 2017-11-02 15:00:07

@pbrezina could you prepare a sssd-1-13 backport when you're done with the access control attestation tool?

If you prefer, I can open a sssd-1-13 ticket just asking for the backport..

---

Comment from jhrozek at 2017-11-02 15:01:42

Metadata Update from @jhrozek:

• Issue set to the milestone: SSSD 1.16.1

---

Comment from pbrezina at 2017-11-06 12:12:47

PR for 1.13:
https//github.com//pull/439

---

Comment from lslebodn at 2017-11-10 14:28:19

sssd-1-13:

• c5d53b0

---

Comment from lslebodn at 2017-11-10 14:28:32

Metadata Update from @lslebodn:

• Issue close_status updated to: Fixed
• Issue status updated to: Closed (was: Open)