Sudo prompt for smart card authentication is missing the trailing colon

[sssd-bot]

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/4049

• Created at 2019-07-31 10:10:33 by jjelen
• Closed at 2019-08-07 18:34:13 as Fixed
• Assigned to nobody
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1736483

---

I configured sudo to authenticate using smart card. The prompt looks like this:

[jjelen@t470s ~]$ sudo true
PIN for jjelen

I think the prompt should end with the colon (mostly because the checks in sudo function use_pam_prompt() [1]) to explicitly mark prompt waiting for user input, as it looks like when sudo asks for password. The format string is defined in [2].

I can propose the trivial pull request, but first of all I wanted to discuss this whether there is not some other reason behind this, that I am missing.

[1] https://www.sudo.ws/repos/sudo/file/tip/plugins/sudoers/auth/pam.c
[2] https://pagure.io/SSSD/sssd/blob/master/f/src/sss_client/pam_sss.c#_1612

Comments

---

Comment from sbose at 2019-07-31 12:11:01

Hi @jjelen,

there is no reason, it is just an error on my side. It would be nice if you can send a pull-request, but please note that we would prefer github (https://github.com/SSSD/sssd/pulls).

bye,
Sumit

---

Comment from jjelen at 2019-07-31 12:25:50

Thank you for fast answers. I opened #856

---

Comment from jhrozek at 2019-07-31 21:03:26

Metadata Update from @jhrozek:

• Issue tagged with: PR, bug

---

Comment from jhrozek at 2019-08-01 20:09:33

Metadata Update from @jhrozek:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1736483

---

Comment from jhrozek at 2019-08-01 20:09:34

Issue linked to Bugzilla: Bug 1736483

---

Comment from sbose at 2019-08-07 18:33:45

Master:

• db46cd0

---

Comment from sbose at 2019-08-07 18:34:14

Metadata Update from @sbose:

• Issue close_status updated to: Fixed
• Issue status updated to: Closed (was: Open)