Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Resolve build warnings #124

Open
2 tasks
jackreimers opened this issue Aug 25, 2023 · 2 comments
Open
2 tasks

♻️ Resolve build warnings #124

jackreimers opened this issue Aug 25, 2023 · 2 comments
Labels
Type: Refactor A code quality improvement e.g. Tech debt

Comments

@jackreimers
Copy link
Contributor

jackreimers commented Aug 25, 2023 •
edited

Cc:

Hi

Pain

When the project is built there are a lot of warnings.

Acceptance Criteria

There should be no warnings when the project builds.

Screenshots

image
Figure: Warnings when building RulesGPT

Thanks!

Tasks
Beta Give feedback
@jackreimers jackreimers added the Type: Refactor A code quality improvement e.g. Tech debt label Aug 25, 2023
@bradystroud
Copy link
Member

Maybe you should turn on warnings as errors
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/errors-warnings#treatwarningsaserrors

Do we have a rule on this?

@jackreimers
Copy link
Contributor Author

I couldn't find any rule on the topic.
I'll add a task to this issue to turn on warnings as errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Refactor A code quality improvement e.g. Tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackreimers @bradystroud