Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Investigate case where RulesGPT suggests MSTest or NUnit instead of XUnit #56

Open
MattParkerDev opened this issue May 22, 2023 · 4 comments
Open

馃悰 Investigate case where RulesGPT suggests MSTest or NUnit instead of XUnit #56

MattParkerDev opened this issue May 22, 2023 · 4 comments
Labels
Type: Bug A problem with existing functionality

Comments

@MattParkerDev
Copy link
Member

Not bad.
Good:

  • Gives the correct link
  • Gives meaningful suggestions

Bad:

  • Proposes to use MSTest...
  • The 5th suggestion is obscure

image

Originally posted by @AntPolkanov in #46 (comment)
@MattParkerDev
Copy link
Member Author

https://www.ssw.com.au/rules/the-most-popular-unit-testing-frameworks-for-net-core-applications/

XUnit is recommended

@jackreimers
Copy link
Contributor

Related to #116

@jackreimers jackreimers changed the title Investigate case where RulesGPT suggests MSTest or NUnit instead of XUnit 馃悰 Investigate case where RulesGPT suggests MSTest or NUnit instead of XUnit Aug 31, 2023
@jackreimers jackreimers added the Type: Bug A problem with existing functionality label Aug 31, 2023
@bradystroud
Copy link
Member

Hey @jackreimers This is probably due to RulesGPT knowing about archive rules
There should be a archived column in the embeddings or simply exclude them from the data

@jackreimers
Copy link
Contributor

Hey @bradystroud, agreed. There's an issue tracking this already #78 which isn't ready to start work on until #48 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug A problem with existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jackreimers @bradystroud @MattParkerDev