Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Azure Pipeline - Simplify the build process #1237

Open
2 tasks
Aibono1225 opened this issue Feb 1, 2024 · 4 comments
Open
2 tasks

♻️ Azure Pipeline - Simplify the build process #1237

Aibono1225 opened this issue Feb 1, 2024 · 4 comments
Assignees
Labels
Type: Refactor A code quality improvement e.g. Tech debt ⛔ Won't do (Fixed next version) A PBI marked by this won't be done in this version of Rules.

Comments

@Aibono1225
Copy link
Member

Cc: @JackDevAU @bradystroud @BrookJeynes @adamcogan

Hi Team,

What code could be improved?

As per my conversation with @JackDevAU, the task "Get History Commits of Each Contributor" is not relevant to the project build. We should move it from the Production & Staging pipeline to UpdateRulesHistory. This will help us reduce the build time by 3 to 4 mins.

Tasks

  • Remove the task from the build pipeline
  • Add it to the UpdateRulesHistory pipeline

Screenshots

image

Thanks!

@Aibono1225 Aibono1225 added the Type: Refactor A code quality improvement e.g. Tech debt label Feb 1, 2024
@Aibono1225
Copy link
Member Author

Aibono1225 commented Feb 4, 2024

Update 04/02/2024:

The task Get History Commits of Each Contributor involves creating a static file commits.json during the Build Pipeline, therefore it cannot be easily moved from one pipeline to another. 🙁
Note: the file commits.json is used for Rules.Widget v1 and users' rule page.

Option A:

Like we did with history.json, in the UpdateRulesHistory pipeline, we store all data for commits.json in the CosmosDB. Then in the Build Pipeline we use an API to get the data and create the json file.

Option B:

Keep the pipeline as it is.

@JackDevAU
Copy link
Member

Hi @Aibono1225

As per our conversation, let's talk to @wicksipedia, @william-liebenberg or @GordonBeeming to see if they have some ideas how we can simplify this build process.

@JackDevAU
Copy link
Member

Hey @Aibono1225

Whats the progress on this?

@Aibono1225
Copy link
Member Author

Update 11/03/2024:

As per my conversation with @wicksipedia , there is another approach to deal with this issue:

Option C:

Separate the task Get History Commits of Each Contributor from the build pipeline. Ideally move it to GitHub Actions for safer token use. Combine the result of both processes into 1 artifact before release.

@Aibono1225 Aibono1225 added the ⛔ Won't do (Fixed next version) A PBI marked by this won't be done in this version of Rules. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor A code quality improvement e.g. Tech debt ⛔ Won't do (Fixed next version) A PBI marked by this won't be done in this version of Rules.
Projects
None yet
Development

No branches or pull requests

2 participants