Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Category template - Add "do you agree" text #1281

Open
3 tasks
bradystroud opened this issue Mar 11, 2024 · 1 comment
Open
3 tasks

✨ Category template - Add "do you agree" text #1281

bradystroud opened this issue Mar 11, 2024 · 1 comment
Labels
Type: Feature A suggested idea for this project

Comments

@bradystroud
Copy link
Member

Cc: @fenix2222 @adamcogan @tiagov8 @matt-goldman

Hi @Aibono1225

I got this task from @fenix2222 and turned it into a PBI.
He asked about wether we should update the text manually or update the template. I think updating the template is the obvious choice.

Tasks

(copy of email SSW Rules - Missing Text from @fenix2222 )
(checked by Adam and Matt G)
Hi Brady,

We noticed this text “Do you agree with them all? Are we missing some? Let us know what you think.” Is missing on all of the rules.

  1. Can we add this into every rule category
  2. Should you add it manually to each rules category or put it into the template?

image
Figure: Example of intro text from an old rule

@bradystroud bradystroud added the Type: Feature A suggested idea for this project label Mar 11, 2024
@tiagov8
Copy link
Member

tiagov8 commented Mar 11, 2024

cc'ing @jaydenalchin / @2fernandez for their inputs

[COPY OF MY EMAIL RESPONSE]

IMO this sentence is unnecessary:

  • We want to encourage people to suggest their edits in a PR instead of “letting us know” (form or email)
  • I doubt these links were ever clicked for years in the past rules… which makes them typically noise
  • We already have a rating and commenting designated area for feedback on each rule
  • We keep forgetting ‘less is more’

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A suggested idea for this project
Projects
None yet
Development

No branches or pull requests

2 participants