Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of ParameterValueSet with ValueArray that have values #318

Open
3 of 9 tasks
antoineatstariongroup opened this issue Jan 8, 2024 · 1 comment
Open
3 of 9 tasks

Comments

@antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET Web Services
  • I have searched open and closed issues to ensure it has not already been reported

Description

It is not possible to create a Parameter with ParameterValueSet that already contains values inside the ValueArray: ParameterValueSet are create via side-effect server side. Same appears when modifying the Option/State dependency.

It should be possible to allow by-passing the side-effect if all provided ParameterValueSet are valid for the Parameter (all possible combination for Option/State dependency present).

On Create:

  • Do not create ParameterValueSet if the payload is valid

On Update:

  • Keep ParameterValueSet where the Option/State dependency are still fine, create or delete invalid once
  • If some ParameterValueSet are provided while updating the Option/State dependency of the Parameter, keep them if payload is valid

Steps to Reproduce

System Configuration

  • COMET Web Services version:
    • CDP4Common:
    • PostrgreSQL:
    • Other:
  • Environment (Operating system, version and so on):
  • .NET Framework version:
  • Mono version:
  • Additional information:
@samatstariongroup
Copy link
Member

I propose a way forward so we don't change the server behaviour too much and we add a dedicated section to the POST message.

now it looks like:

{
  "_create": [],
  "_update": [],
  "_delete": [],
  "_copy": [],
  "_values":[]
}

in the Values property we can put a list of ParameterValueSets (with reference to the container Parameter or PArameterOverride.

@samatstariongroup samatstariongroup moved this from Estimate 12-05-2023 to Backlog in COMET-CE May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
COMET-CE
  
Backlog
Development

No branches or pull requests

2 participants