Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composable_guard test is broken when having more than one thread #1046

Closed
sithhell opened this issue Jan 15, 2014 · 5 comments
Closed

composable_guard test is broken when having more than one thread #1046

sithhell opened this issue Jan 15, 2014 · 5 comments

Comments

@sithhell
Copy link
Member

Currently, the composable guard test fails to run on more than 1 OS thread.
The main reason is because the tasks started with run_guarded can not be synchronized on, leading to the fact that the apply function gets executed after the call to hpx::finalize. I think it would be wise for those functions to return a hpx::unique_future of some sorts.

@ghost ghost assigned stevenrbrandt Jan 15, 2014
@hkaiser
Copy link
Member

hkaiser commented Jan 20, 2014

Any news on this?

@stevenrbrandt
Copy link
Member

I added a future, as suggested.

@stevenrbrandt
Copy link
Member

Should be fixed now.

@hkaiser
Copy link
Member

hkaiser commented Jan 21, 2014

For the records, this was fixed by 786918a and 12a9bac.

However I believe that you should still leave that call to hpx::finalize in place. Does the test even exit properly without it?

@stevenrbrandt
Copy link
Member

It executes fine for me, but I see what you mean. 2ab6deb puts the hpx::finalize back in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants