Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack overflow detection producing false positives #2987

Closed
biddisco opened this issue Nov 5, 2017 · 7 comments
Closed

stack overflow detection producing false positives #2987

biddisco opened this issue Nov 5, 2017 · 7 comments

Comments

@biddisco
Copy link
Contributor

biddisco commented Nov 5, 2017

I have bugs in my code that cause segfaults. however the new stack overflow detection is frequently producing messages such as
"Stack overflow in coroutine at address 0x000056036def3790"

I'm not sure if anything can be done about this, or if it is serious enough to fix - since a genuine stack-overflow might be indistinguishable from a silly memory access error. I'm reporting this just in case the stack overflow detection can be improved.

@hkaiser
Copy link
Member

hkaiser commented Nov 5, 2017

As far as I'm aware, @ct-clmsn is already working on finding a solution.

@ct-clmsn
Copy link
Contributor

ct-clmsn commented Nov 5, 2017

@hkaiser @biddisco on it - getting close to a preliminary solution. hope to have something debugged by the end of today.

@justwagle
Copy link
Member

justwagle commented Nov 20, 2017

@diehlpk I think you can configure HPX with HPX_WITH_THREAD_STACKOVERFLOW_DETECTION=OFF.

@hkaiser
Copy link
Member

hkaiser commented Nov 20, 2017

We currently have two options: HPX_WITH_THREAD_STACKOVERFLOW_DETECTION and HPX_WITH_STACKOVERFLOW_DETECTION which is a bug.

@ct-clmsn
Copy link
Contributor

ct-clmsn commented Nov 21, 2017

@biddisco @hkaiser I'll be pushing a solution to merge for review this afternoon/evening. Still having issues getting a platform together that can be used to debug the work correctly. The "Ubuntu for Windows" environment has some issues that are making the stackoverflow detection a challenge to debug.

@hkaiser
Copy link
Member

hkaiser commented Nov 21, 2017

See #3016 and #3018 for fixes to the configuration mess.

@hkaiser hkaiser mentioned this issue Nov 22, 2017
@hkaiser
Copy link
Member

hkaiser commented Dec 31, 2017

This has been fixed by merging #3021

@hkaiser hkaiser closed this as completed Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants