Fix test errors with _GLIBCXX_DEBUG defined
#5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
glibcxx-debug
branch
from
c036b68
to
9657d5b
Compare
|
Force-push only fixed formatting. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
5693: Fix test errors with `_GLIBCXX_DEBUG` defined r=msimberg a=msimberg Fixes part of #5544. The `is_heap` change is due to `greater_equal` not satisfying https://en.cppreference.com/w/cpp/named_req/Compare. With `_GLIBCXX_DEBUG` libstdc++ actually gives a surprisingly helpful error message: ``` 57: In function: 57: _RAIter std::is_heap_until(_RAIter, _RAIter, _Compare) [with _RAIter = 57: __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<int*, 57: std::__cxx1998::vector<int, std::allocator<int> > >, 57: std::__debug::vector<int>, std::random_access_iterator_tag>; _Compare = 57: std::greater_equal<int>] 57: 57: Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)). 57: 57: Objects involved in the operation: 57: instance "functor" @ 0x0x2b53cad26267 { 57: type = std::greater_equal<int>; 57: } 57: iterator::value_type "ordered type" { 57: type = int; 57: } ``` The change to `is_contiguous_iterator` is because vector iterators are different with `_GLIBCXX_DEBUG` (the pointers are wrapped). The last change to `incplace_merge` tests is due to confused use of variables. With `_GLIBCXX_DEBUG` libstdc++ reported use of moved-from iterators. There are still a few tests that fail with `_GLIBCXX_DEBUG`, so I'm not enabling it in CI. If anyone feels like looking into them they're at least `uninitialized_copyn` and `uninitialized_move`. They both segfault. Co-authored-by: Mikael Simberg <mikael.simberg@iki.if>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #5544.
The
is_heapchange is due togreater_equalnot satisfying https://en.cppreference.com/w/cpp/named_req/Compare. With_GLIBCXX_DEBUGlibstdc++ actually gives a surprisingly helpful error message:The change to
is_contiguous_iteratoris because vector iterators are different with_GLIBCXX_DEBUG(the pointers are wrapped).The last change to
incplace_mergetests is due to confused use of variables. With_GLIBCXX_DEBUGlibstdc++ reported use of moved-from iterators.There are still a few tests that fail with
_GLIBCXX_DEBUG, so I'm not enabling it in CI. If anyone feels like looking into them they're at leastuninitialized_copynanduninitialized_move. They both segfault.