Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems using the hpx.stacks:use_guard_pages parameter #6288

Closed
G-071 opened this issue Jun 23, 2023 · 2 comments · Fixed by #6296
Closed

Problems using the hpx.stacks:use_guard_pages parameter #6288

G-071 opened this issue Jun 23, 2023 · 2 comments · Fixed by #6296
Milestone

Comments

@G-071
Copy link
Member

G-071 commented Jun 23, 2023

To run larger scenarios with Octo-Tiger on a single node, we usually have to add the parameter --hpx.stacks:use_guard_pages=0. Recently (not quite sure when this started to happen), passing this parameter caused an issue within Octo-Tiger though:

terminate called after throwing an instance of 'boost::wrapexcept<boost::program_options::unknown_option>'
  what():  unrecognised option '--hpx.stacks:use_guard_pages=0'

Note, that this error is thrown when Octo-Tiger itself is parsing its CLI parameters (well after hpx::init).

Simply adding the parameter to the Octo-Tiger command used to work without any issue! Has something recently changed regarding the HPX CLI parameters, which might cause this one to be forwarded to Octo-Tiger somehow?

@hkaiser hkaiser added this to the 1.9.1 milestone Jun 24, 2023
@hkaiser
Copy link
Member

hkaiser commented Jun 24, 2023

The option should be --hpx:ini=hpx.stacks.use_guard_pages!=0. Did the option you list ever work before?

@G-071
Copy link
Member Author

G-071 commented Jun 26, 2023

Ah, a typo sneaked into the original issue text - I meant -Ihpx.stacks.use_guard_pages=0. Same issue though!

This flag is actually recommended by the exception HPX throws in case use_guard_pages=0 is required (but not set):

{what}: mmap() failed to allocate thread stack due to insufficient resources, increase /proc/sys/vm/max_map_count or add -Ihpx.stacks.use_guard_pages=0 to the command line: HPX(unhandled_exception)

I believe it's this exception here.
If memory serves, that flag used to work, as the common scenario was to hit this exception with certain octotiger configurations and add the flag afterwards to fix it! It has been a while since I needed it though.

That being said, the flag you gave me works as intended! It is probably best to change the text for the exception accordingly, as adding this flag on-demand after hitting the exception will probably remain a common scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants