Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register bit name typo causes compiler warning due to bug #9

Open
nroff-man opened this issue Sep 2, 2023 · 2 comments
Open

Register bit name typo causes compiler warning due to bug #9

nroff-man opened this issue Sep 2, 2023 · 2 comments
Assignees
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Milestone

Comments

@nroff-man
Copy link

There is a typo in the LL_PWR include for H5XX

This typo uses the wrong bit name:

Drivers/STM32H5xx_HAL_Driver/Inc/stm32h5xx_ll_pwr.h:1507:106: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
1507 | return ((READ_BIT(PWR->VMSR, PWR_VMSR_PVDO) == (PWR_VMSR_AVDO)) ? 1UL : 0UL);

The correction is to read the bit PWR_VMSR_AVDO and not PWR_VMSR_PVDO

bye.

@fpistm
Copy link

fpistm commented Sep 2, 2023

For ref: stm32duino/Arduino_Core_STM32#2119

@ALABSTM ALABSTM added bug Something isn't working hal HAL-LL driver-related issue or pull-request. labels Sep 5, 2023
@ALABSTM ALABSTM added this to To do in stm32cube-mcu-fw-dashboard via automation Sep 5, 2023
@TOUNSTM
Copy link
Contributor

TOUNSTM commented Sep 11, 2023

ST Internal Reference: 161158

@TOUNSTM TOUNSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Sep 11, 2023
@TOUNSTM TOUNSTM moved this from To do to In progress in stm32cube-mcu-fw-dashboard Sep 11, 2023
@KRASTM KRASTM added this to the v1.3.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Projects
Development

No branches or pull requests

5 participants