Skip to content

Commit

Permalink
JP-3612: Fix MOS background slit source position (#8461)
Browse files Browse the repository at this point in the history
Co-authored-by: Nadia Dencheva <nadia.dencheva@gmail.com>
  • Loading branch information
melanieclarke and nden committed May 8, 2024
1 parent 854f84b commit c9e8275
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ assign_wcs
of pixel row rather than a rotation of the pixel coordinates. The practical impact is
to ensure that iso-lambda is along pixel rows after this change. [#8411]

- Move the assigned source position for dedicated NIRSpec MOS background slits from the
lower left corner of the slit to the middle of the slit. [#8461]

associations
------------

Expand Down
4 changes: 2 additions & 2 deletions jwst/assign_wcs/nirspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,8 @@ def get_open_msa_slits(msa_file, msa_metadata_id, dither_position,
quadrant = slitlets_sid[0]['shutter_quadrant']
ycen = j
xcen = slitlets_sid[0]['shutter_row'] # grab the first as they are all the same
source_xpos = 0.0
source_ypos = 0.0
source_xpos = 0.5
source_ypos = 0.5
source_id = _get_bkg_source_id(bkg_counter, max_source_id)
log.info(f'Slitlet_id {slitlet_id} is background only; assigned source_id = {source_id}')
bkg_counter += 1
Expand Down
2 changes: 1 addition & 1 deletion jwst/assign_wcs/tests/test_nirspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def test_msa_configuration_all_background():
slitlet_info = nirspec.get_open_msa_slits(msaconfl, msa_meta_id, dither_position,
slit_y_range=[-.5, .5])
ref_slit = trmodels.Slit(57, 8281, 1, 251, 23, -2.15, 2.15, 4, 0, '1x1', 'background_57', 'bkg_57',
0, -0.5, -0.5)
0, 0.0, 0.0)
_compare_slits(slitlet_info[0], ref_slit)


Expand Down

0 comments on commit c9e8275

Please sign in to comment.