Instance no longer returned on present(on:) in 1.4.1

[dhritzkiv]

Describe the bug
In 1.3.2 it was possible to retrieve the instance of the view controller after calling present:

let countryController = CountryPickerWithSectionViewController.presentController(on: self) { ... }

^ that's from the README

Now, the call returns ()

If this is no longer supported, 1.4.1 should have been 2.0.0, as that's a breaking change

[Sharkesm]

@dhritzkiv Good point that you raised.

@SURYAKANTSHARMA Could we proceed with updating the README based on the recent changes that you made.

[SURYAKANTSHARMA]

@dhritzkiv read me already updated please check https://github.com/SURYAKANTSHARMA/CountryPicker#readme cc @Sharkesm
between why you need instance at first place ?

there is other function for that if you need manual presentation on your navigation etc

 CountryPickerWithSectionViewController.presentController(on: self, configuration: { countryController in
            // You can still capture here in you need to but not recommended 
        }) { [weak self] country in
            
          
        }

[SURYAKANTSHARMA]

@Sharkesm should we close this or do you want me to upgrade the version ?

[dhritzkiv]

In 1.3.2 I was doing this:

let countryController = CountryPickerWithSectionViewController.presentController(on: self) { [weak self] (country: Country) in
    // code
}

countryController.title = "" // custom title

countryController.detailFont = UIFont.systemFont(ofSize: 17)
countryController.detailColor = UIColor.systemGray
countryController.labelFont = UIFont.systemFont(ofSize: 17)
countryController.labelColor = UIColor.systemGray

countryController.flagStyle = .corner

I'm unable to apply these in the configuration block

[Sharkesm]

@dhritzkiv I think you can still apply the configuration of the controller as instructed on the README file.

@SURYAKANTSHARMA For that case since there's code-breaking would be best to update the versioning to avoid any confusion and cross-check the styling section of the README file as well.

[dhritzkiv]

It doesn't look to be the case. More than just that API changed:

[SURYAKANTSHARMA]

use countryController. configuration.detailFont will update major version.

[Sharkesm]

@dhritzkiv Updated the README file on the styling section. Please confirm as to whether the styling configuration is exposed for the current version or else we may proceed to close this thread.

cc/ @SURYAKANTSHARMA

[SURYAKANTSHARMA]

I have not delete live version as per this. but had updated new version will reflect soon 2.0.0