Add SSH Provider #115
Add SSH Provider #115
Conversation
smarlowucf
commented
Aug 9, 2018
•
smarlowucf
commented
- Allows for testing of an instance based on SSH. No provider credentials are necessary.
- Add ip address option for SSH testing.
| @@ -133,6 +133,11 @@ For more information on updating an existing service account: | |||
| - Granting roles: | |||
| [granting-roles-to-service-accounts](https://cloud.google.com/iam/docs/granting-roles-to-service-accounts) | |||
|
|
|||
| SSH | |||
| --- | |||
| Requires no provider credentials to test instances. SSH user, SSH private key can | |||
There was a problem hiding this comment.
Lets also support a pointer to a private key file. Differentiating his in the code is a simple if condition.
There was a problem hiding this comment.
This is a key file. It is poorly named:
--ssh-private-key PATH SSH private key file for accessing instance.
We can change the name for CLI but probably want to deprecate it then drop it in a major release:
--ssh-private-key-file PATH SSH private key file for accessing instance.
I don't think it should be expected that anyone would pass a private key in command line so just providing the key file option seems good.
There was a problem hiding this comment.
Please change according to the other Provider class changes
There was a problem hiding this comment.
Please change according to the other Provider class changes
Rebased against master.
ipa/ipa_provider.py
Outdated
| @@ -575,7 +593,10 @@ def test_image(self): | |||
| Returns: | |||
| A tuple with the exit code and results json. | |||
| """ | |||
| if self.running_instance_id: | |||
| if self.provider == 'ssh': | |||
| # SSH provider: instance must running | |||
There was a problem hiding this comment.
Fixed and rebased
ipa/ipa_ssh.py
Outdated
| self.ssh_private_key = ( | ||
| ssh_private_key or | ||
| self._get_value(ssh_private_key, config_key='ssh_private_key') | ||
| ) |
There was a problem hiding this comment.
if os.path.isfile(self.ssh_private_key):
self.ssh_private_key = self.ssh_private_key.read()
There was a problem hiding this comment.
See previous comment. The key file path is passed directly into SSH commands, not the value.
ipa/ipa_ssh.py
Outdated
| else: | ||
| self.ssh_private_key = os.path.expanduser( | ||
| self.ssh_private_key | ||
| ) |
There was a problem hiding this comment.
Hmm there is some inconsistency with this implementation vs. my assumption based on the doc. Pleas reconcile.
There was a problem hiding this comment.
As per previous comments you cannot pass in a private key string. The CLI validates the string is a path and the file exists.
There was a problem hiding this comment.
@click.option(
'--ssh-private-key',
type=click.Path(exists=True),
help='SSH private key file for accessing instance.'
)
smarlowucf
force-pushed
the
ssh-provider
branch
from
988c809
to
9c6c870
Compare
smarlowucf
force-pushed
the
ssh-provider
branch
2 times, most recently
from
618882f
to
00c1f4b
Compare
Allows for testing of an instance based on SSH. No provider credentials are necessary.
Add info on SSH provider.
smarlowucf
force-pushed
the
ssh-provider
branch
from
00c1f4b
to
c14c832
Compare
