Add ec2 tests to check billing code in metadata. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving shared code to conftest... |
For byos images the billingProducts should be None. And for on demand the billingProducts should be a list of strings.
|
Okay re-based removing duplication. |
|
@rjschwei Look good? |
rjschwei
requested changes
Jun 15, 2018
| @@ -0,0 +1,4 @@ | |||
|
|
|||
|
|
|||
| def test_sles_ec2_billing_code(get_ec2_billing_products): | |||
There was a problem hiding this comment.
Please add the following.
"""This is really ONLY for SLES. All other on-demand products are sold through the Marketplace and they do not have a billing-product-code."""
rjschwei
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For byos images the billingProducts should be None. And for on demand the billingProducts should be a list of strings.