Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove additional_repo and add pkg and add modules #152

Closed
MalloZup opened this issue Sep 3, 2019 · 4 comments
Closed

remove additional_repo and add pkg and add modules #152

MalloZup opened this issue Sep 3, 2019 · 4 comments

Comments

@MalloZup
Copy link
Contributor

MalloZup commented Sep 3, 2019

info:

We should remove un-used variables for keep codebase minimal.

This 3 variables at least 2 (add repo and add pkgs) aren't really needed for our use-cases.

The add-modules perhaps

@MalloZup
Copy link
Contributor Author

MalloZup commented Sep 3, 2019

assigning people for sharing thoughs!

@MalloZup
Copy link
Contributor Author

MalloZup commented Sep 3, 2019

an historic thing: if we need to introduce devel_mode variable this mean that this 2 variable are also more useless then neeeded.

I think in a way encouraging to install pkg is not needed. If people want to add Additional pkgs, they can do later after install/ We should own the control of input and remove vars as possible.

@arbulu89
Copy link
Collaborator

I wouldn't remove features that are already tested and working.
In my opinion they don't add much maintenance work and are quite easy to manage.
Removing things is quite tricky as we don't know if anyone is using them. I know that this project is still small and doesn't have users except us, but we always need to think about the impact of these changes.
PD:
The reg_additional_modules is in fact used to add PackageHub packages.

@MalloZup
Copy link
Contributor Author

we have removed some of the vars. right now I think this is issue got staled and we can remove vars in future if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants