Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha_exporter installed by default #181

Closed
arbulu89 opened this issue Sep 19, 2019 · 0 comments · Fixed by #184
Closed

ha_exporter installed by default #181

arbulu89 opened this issue Sep 19, 2019 · 0 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers monitoring

Comments

@arbulu89
Copy link
Collaborator

Right now, the ha_exporter is installed by default, without considering if the monitoring stack is created or not.
In order to align all the component, the ha_exporter should be only installed together with the whole monitoring stack.
What do you think?
For that, we should just set this value to False in the cloud_providers (aws and gcp don't even have monitoring stack) and in the automatic pillar example depending on the monitoring_enabled parameter.

Examples:
https://github.com/SUSE/ha-sap-terraform-deployments/blob/master/pillar_examples/aws/cluster.sls#L13
https://github.com/SUSE/ha-sap-terraform-deployments/blob/master/pillar_examples/automatic/cluster.sls#L29

In fact, we should take advantage, and do the same with the hanadb_exporter (only enable according this monitoring_enabled parameter.

@arbulu89 arbulu89 added good first issue Good for newcomers bug Something isn't working enhancement New feature or request monitoring and removed bug Something isn't working labels Sep 19, 2019
@MalloZup MalloZup self-assigned this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers monitoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants