Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name_prefix should be removed #93

Closed
MalloZup opened this issue Jul 3, 2019 · 2 comments
Closed

name_prefix should be removed #93

MalloZup opened this issue Jul 3, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MalloZup
Copy link
Contributor

MalloZup commented Jul 3, 2019 •
edited

Problem/desc:

we have currenlty name-prefix as tfvars.

https://github.com/SUSE/ha-sap-terraform-deployments/search?q=name_prefix&unscoped_q=name_prefix

We don't need this variable since we can take it form the workspace name as we did in past.

e.g see: https://github.com/SUSE/ha-sap-terraform-deployments/blob/master/libvirt/terraform/modules/base/main.tf#L6
@MalloZup MalloZup added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2019
@MalloZup MalloZup mentioned this issue Aug 30, 2019
Closed
@arbulu89
Copy link
Collaborator

Hey @MalloZup ,
This change is already done, isn't it? name-prefix is only used internally now.
In that case we can close the issue.

@MalloZup
Copy link
Contributor Author

Ah yes right let close it for moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MalloZup @arbulu89