Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New collaborators to keep the component alive? #361

Closed
honkmaster opened this issue Nov 4, 2014 · 36 comments
Closed

New collaborators to keep the component alive? #361

honkmaster opened this issue Nov 4, 2014 · 36 comments

Comments

@honkmaster
Copy link
Member

Dear Sam.

SVProgressHUD is used in many many Apps, therefore it is important to keep the component up to date. This include especially bugfixes for recent OS updates like iOS 8. As you can see this is not the case anymore (#342, #351, #334, #331, ...). The community is providing Pull-Request for these problems, however they are not merged <=> the master branch is inactive, the component quasi defective on iOS 8.

You have done great work in the last years regarding this component. However, in consideration of the current state I would like to ask you to think about how to continue with this component. How could the community help you to keep the component alive. My idea: Add collaborators to the project, which for example may merge Pull-Requests in the future. What do you think?

BR

@honkmaster honkmaster changed the title New collaborators? New collaborators to keep the component alive? Nov 4, 2014
@patoroco
Copy link

patoroco commented Nov 4, 2014

👍

1 similar comment
@jrwagz
Copy link

jrwagz commented Nov 5, 2014

👍

@EvgenyKarkan
Copy link

Sad of silence here... great control, but so outdated.

@honkmaster
Copy link
Member Author

Seems like even his mail server is not responding.

The address to which the message has not yet been delivered is:

hello@samvermette.com

No action is required on your part. Delivery attempts will continue for
some time, and this warning may be repeated at intervals if the message
remains undelivered.

What to do next? Fork and continue from there on?

@rsanchezsaez
Copy link

@honkmaster Yeah, I think that the sensible thing to do now is to fork it and continue there. Whoever forks it, make sure to enable 'Issues' for your fork, so people is able to report problems.

Expectedly, the SVProgressHUD Cocoapod is unclaimed, so after you have made a fork you should be able to claim it using this form.


A similar issue happened with WYPopoverController: the original repo was abandoned. sammcewan forked it and maintenance is taking place there.

It'd be great if GitHub tagged "abandoned" repos somehow, to let new visitors now that they would be better off looking for an alternate active fork.

@honkmaster
Copy link
Member Author

i will wait another week for Sam to react. During this period, I would be happy to hear some other opinions.

@vtourraine
Copy link
Contributor

If we decide to fork it, it might be better to change the name.

@rsanchezsaez
Copy link

@vtourraine: Why? Since nobody has claimed the original Cocoapod I don't see the ned.

Not changing the name is working fine for WYPopoverController.

@vtourraine
Copy link
Contributor

If Sam agrees to hand us over the project, fine, keep the name. If not, I’d argue that we should find a new name (related: the whole “Standard Markdown” thing, even if the situation is a bit different).

@rsanchezsaez
Copy link

Good point.

But I think that if somebody goes MIA and leaves their open source projects (and their users) orphaned, he might expect a fork (with the same name) trying to take over.

Anyway, both options look good. I guess it won't make much of a difference.

@patoroco
Copy link

I vote to continue with the same name.

I don't have too much time to be the main fork, but I think that a good solution should be contact with maximum contributors to the project, and ask it if they would take the own of the project, I think that it will be the most "democratic" and meritocratic way, what do you think?

@Dids
Copy link

Dids commented Nov 21, 2014

It's been over a week. I vote for a fork asap, but I don't really mind if the name changes, either way, I'm in!

@honkmaster
Copy link
Member Author

OK. I forked the component to https://github.com/honkmaster/SVProgressHUD. I am happy for everybody who wants to help. Please send me a message and I will add you to the collaborators. I will create a "template text" that I will post under all newly created and existing pull-reuests and bugs to notify people of the change.

@rsanchezsaez
Copy link

Thumbs up! Make sure to claim the Cocoapod as well so everything is ready to start submitting updates. ;-)

@Dids
Copy link

Dids commented Nov 21, 2014

Great! I just hope that the pull requests/fixes get merged in a somewhat rapid fashion. :)

@Dids
Copy link

Dids commented Nov 25, 2014

Apparently Sam's back and merging pull requests.

@honkmaster
Copy link
Member Author

I do not understand whats up whit this repo....

@patoroco
Copy link

@samvermette is noticed about this trend / issue? Should be interesting that he participe here.

@honkmaster
Copy link
Member Author

I tried to send him multiple mails to his public mail address (see above). Additionally he should be aware of this issue because he is the owner of this repo. However, till he perticipates in this thread we know absolutely nothing.

@lumaxis
Copy link
Contributor

lumaxis commented Nov 25, 2014

Also, the PRs he's merging seam not to always make sense/be very good fixes...

@honkmaster
Copy link
Member Author

He has to decide what he wants to merge, it is his repository, I dont mind. I am very happy to see at least some activity of @samvermette.

@samvermette
Copy link
Contributor

Hey everyone. First off I'd like to apologize for this lasting silence. As some of you know maintaining open source code is time-consuming, and as I took on new projects I was able to dedicate less and less time to my SV classes. I also started using GitHub for other projects and eventually decided to mute all notifications for my SV projects (bad move), which led me to only find out about this thread now.

We've been using SVProgressHUD in Transit and it's been running great on iOS 7 and 8, so I guess that made me to believe the class didn't need any urgent fixes. That being said the project has been crawling under issues and PRs for over a year now and I agree I can no longer keep up with them.

I'm more than open to adding one or many collaborators that can help this project live on. However as some of you know I've been very picky with new features and reluctant to adding new methods to the class interface. Knowing when to say "no" to issues and or pull requests is in my opinion one of the toughest thing with open source, and I wouldn't want SVProgressHUD to become a bloated class with tens of methods to accommodate each individual request. Good design is opinionated as they say...

Is there anyone in this thread connecting with what I'm saying here and would like to give SVProgressHUD a second life? Feel free to discuss here or you can also send me an email: sam@thetransitapp.com

@honkmaster
Copy link
Member Author

raising hand

@honkmaster
Copy link
Member Author

I am on board now and will go through some PR now.

@honkmaster
Copy link
Member Author

Even if I am on board now I would be happy if anybody else would like to be a contributor as well.

@vtourraine
Copy link
Contributor

Do you also have the CocoaPods Trunk credentials? I’m sure you know, but that’d be great to see the latest updates released with a new version there.

@honkmaster
Copy link
Member Author

I have the cocoapods credentials. I will submit an update by the end of the week.

@vtourraine
Copy link
Contributor

Fantastic!

@honkmaster
Copy link
Member Author

Just submitted 1.1

@EvgenyKarkan
Copy link

👍

@hardikdevios
Copy link

@honkmaster mate if you are going to give a second life to SVHUD .. than you are the best mate of my life i have been using this for a longer time but as you know guys are complaining about the issue regarding iOS 8 and cocoapoads but its good to here that you are now going to take the responsibilities.. so my first idea for this is to make it Blur background instead of gradient so let me know if we had any success with that i alrady checked your code for applying first part of blur effect using UIVisualEffects so l am very excited about that 👍

@honkmaster
Copy link
Member Author

thanks @hardikdevios. In regards to your idea with blur background. We try to adjust our appearance to UIAlertView and UIAlertController. These components do not blur the background, so does SVProgressHUD.

@vtourraine
Copy link
Contributor

I agree that it’s the best way to maintain this project: treat it like it’s part of UIKit.

@honkmaster
Copy link
Member Author

That's my idea of this project;)...this is also the reason why I simplify the interface at the moment (see #384).

@honkmaster
Copy link
Member Author

Will close for now. Component is back in active development.

@samvermette
Copy link
Contributor

You're doing an incredible job @honkmaster, thanks for taking over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants