Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to attach to view so both can dismiss at the same time #783

Closed
timroesner opened this issue Jul 26, 2017 · 9 comments
Closed

Option to attach to view so both can dismiss at the same time #783

timroesner opened this issue Jul 26, 2017 · 9 comments
Labels

Comments

@timroesner
Copy link

Steps to reproduce:

  1. Go to view with SVProgressHUD
  2. Progress spinner appears
  3. Leave view before spinner is dismissed
  4. Spinner will never disappear

Expected result:

  1. Go to view with SVProgressHUD
  2. Progress spinner appears
  3. Leave view before spinner is dismissed
  4. Spinner disappears with view

I know this can be achieved with dismissing the ProgressHUD in the viewWillDisappear method but I would prefer not doing that in every view that I am presenting a ProgressHUD. MBProgressView does offer this option for example, but they don't have a flat UI.

@honkmaster
Copy link
Member

Thanks for this exemplary report. I will look into this, however, if you could provide a minimal demo project this would help alot and speed up the process as my time is very limited.

@timroesner
Copy link
Author

timroesner commented Jul 26, 2017

Of course! Just use timroesner/9to5Mac as an example project. You can reproduce it when you back out of the article view before the spinner disappears.

PR #753 talks about this issue as well

@toohotz
Copy link

toohotz commented Aug 10, 2017

@timroesner would it be something like this that you are looking to achieve? I made this PR after running into a similar issue that you stated.
https://github.com/SVProgressHUD/SVProgressHUD/pull/753

@timroesner
Copy link
Author

Yes exactly, if that PR isn't merged soon I'll just use your branch

@toohotz
Copy link

toohotz commented Aug 14, 2017

@timroesner Sure, I'll keep my fork updated with the master fork if / when my PR does get merged in

@timroesner
Copy link
Author

@toohotz Thank you! I appreciate that, I'll be using your fork then

@honkmaster
Copy link
Member

#753 is to cluttered for a single PR at the moment to be merged into the master.

@toohotz
Copy link

toohotz commented Aug 14, 2017

@honkmaster saw your message, I'll split them into two PRs, thanks.

@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the stale label Feb 13, 2018
@stale stale bot closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants