-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to attach to view so both can dismiss at the same time #783
Comments
Thanks for this exemplary report. I will look into this, however, if you could provide a minimal demo project this would help alot and speed up the process as my time is very limited. |
Of course! Just use timroesner/9to5Mac as an example project. You can reproduce it when you back out of the article view before the spinner disappears. PR #753 talks about this issue as well |
@timroesner would it be something like this that you are looking to achieve? I made this PR after running into a similar issue that you stated. |
Yes exactly, if that PR isn't merged soon I'll just use your branch |
@timroesner Sure, I'll keep my fork updated with the master fork if / when my PR does get merged in |
@toohotz Thank you! I appreciate that, I'll be using your fork then |
#753 is to cluttered for a single PR at the moment to be merged into the master. |
@honkmaster saw your message, I'll split them into two PRs, thanks. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
Steps to reproduce:
Expected result:
I know this can be achieved with dismissing the ProgressHUD in the viewWillDisappear method but I would prefer not doing that in every view that I am presenting a ProgressHUD. MBProgressView does offer this option for example, but they don't have a flat UI.
The text was updated successfully, but these errors were encountered: