Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curriculum editor's file uploader should check file size before uploading #101

Closed
harigopal opened this issue Oct 29, 2019 · 1 comment
Closed

Curriculum editor's file uploader should check file size before uploading #101

harigopal opened this issue Oct 29, 2019 · 1 comment
Assignees
@harigopal
Labels
enhancement New feature or request
Projects
Development

Comments

@harigopal
Copy link
Member

harigopal commented Oct 29, 2019 •
edited

Right now, it doesn't seem to have any client-side check, which means that a file has to be fully uploaded before the server can reject it, which is just silly.

An example of such a client-side check can be found in the MarkdownEditor.re's attachFile function.
@harigopal harigopal added the enhancement New feature or request label Oct 29, 2019
@harigopal harigopal added this to To do in Development via automation Oct 29, 2019
@harigopal harigopal moved this from To do to Up Next in Development Oct 29, 2019
bodhish added a commit that referenced this issue Nov 6, 2019
@bodhish
Add client side validation for file upload in SA:CE #101
82eb2fe
@bodhish bodhish moved this from Up Next to Needs review in Development Nov 6, 2019
@bodhish bodhish self-assigned this Nov 7, 2019
@harigopal
Copy link
Member Author

This still isn't really fixed because the save button is enabled even after the warning about file being too large is displayed. This should be tackled when we rework the curriculum editor.

@harigopal harigopal moved this from Needs review to Up Next in Development Nov 18, 2019
@bodhish bodhish removed their assignment Nov 19, 2019
@harigopal harigopal moved this from Up Next to In progress in Development Dec 23, 2019
@harigopal harigopal self-assigned this Dec 23, 2019
@harigopal harigopal mentioned this issue Dec 24, 2019
Closed
5 tasks
@harigopal harigopal moved this from In progress to Up Next in Development Jan 9, 2020
@harigopal harigopal moved this from Up Next to In progress in Development Jan 16, 2020
@mahesh-krishnakumar mahesh-krishnakumar mentioned this issue Feb 3, 2020
Merged
2 tasks
Development automation moved this from In progress to Done Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harigopal harigopal

Labels
enhancement New feature or request
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harigopal @bodhish