MSTR-98 : 문제 채점 API 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 최고점 최저점을 반대로 응답하던 이슈 수정
|
Kudos, SonarCloud Quality Gate passed!
|
- NPE가 발생할 수 있는 조건 수정
Kim-Hyunjo
reviewed
Aug 17, 2022
Comment on lines
12
to
13
| val topScore: Double?, | ||
| val bottomScore: Double?, |
There was a problem hiding this comment.
그때 같이 피그마 만들면서 단답형, 객관식은 topScore, bottomScore 대신에 맞은 사람 수, 틀린 사람 수로 바꿨던 기억이 있는데 해당부분이 반영되었을까요?? 객관식, 단답형 문제에서는 최고점 최저점이 의미가 없을것같아서요..!
There was a problem hiding this comment.
- 맞은 사람 수, 틀린 사람 수를 응답하도록 수정
- DTO 변경에 따른 테스트 수정
|
@Kim-Hyunjo 수정사항 반영해서 push 했습니다. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: MSTR-98
작업 내역
변경사항
작업 유형
PR 특이 사항