Wrong hmac values when the key contains "null" bytes

[jinwoo]

For example, crypto_data_hash gives the same hash value for keys [1,0,1] and [1]. I notice that strlen is used to calculate the key length:

packages-ssl/crypto4pl.c

Line 396 in acb9607

(unsigned char*)context->mac_key, strlen(context->mac_key),

and

packages-ssl/crypto4pl.c

Line 407 in acb9607

context->mac_key, strlen(context->mac_key),

. It'd work when the key is a string but wouldn't work when the key is a binary data.

?- Key = [1], crypto_data_hash(`foo`, Hash, [algorithm(sha256),hmac(Key)]).
Key = [1],
Hash = '63a592e348d812a8027985ecfc6e0df958e9177437e59a182037ada35a4636e8'.

?- Key = [1,0,1], crypto_data_hash(`foo`, Hash, [algorithm(sha256),hmac(Key)]).
Key = [1, 0, 1],
Hash = '63a592e348d812a8027985ecfc6e0df958e9177437e59a182037ada35a4636e8'.

[JanWielemaker]

This issue has been mentioned on SWI-Prolog. There might be relevant details there:

https://swi-prolog.discourse.group/t/wrong-hmac-values-from-crypto-data-hash/7256/1