New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help migrating away from ORES #1
Comments
@SiarheiGribov @ajbura @kfiven Hi! Do you know who I can talk with for this migration? Thanks in advance :) |
Hello, @elukey . You can join our discord server.
|
Hi!
We are deprecating the revision-score stream, and we'll create new ones (one model score type for each stream) but it will be on demand, do you have any specific requirements? I think that the latency will be some seconds after an edit happens, not faster than that :)
I am not 100% sure, do you need only oauth1.0 or is it ok oauth2.0 too?
With internal endpoints we mean inside the WMF infrastructure, but for the outside world we have anonymous access without bearer token (at the moment limited to 10000 requests/hour).
I don't think we have at the moment, since our new infrastructure is one micro-service for each model. We support the same model that ORES supports, plus other ones, but if you need the list for a specific use case we can work on having one.
Not at all, I am a non native english speaker, yours is great. Thanks for taking the time! |
I really don't want to check the pages (1 and 2) and update my code when adding supported new wiki :).
In my opinion, a better option would be to set token / private key on api.wikimedia without oAuth. oAuth2.0 requires updating token every 4 hours (extra sourcecode), and oauth1.0 is too complicated. oAuth also imposes a requirement to hide oAuth credentials (browser-based JavaScript client apps?). ORES was very easy to use, but now we need to create a large project, 90% of which will be authorization logic. This doesn't scare me (I have projects for Wikimedia on 1.0 and 2.0 oAuth), but for others it increases the threshold. |
@SiarheiGribov toolforge is separated from the Wikimedia production infrastructure, so your client needs to go through the API gateway (like it was a regular client in the outside Internet). You can test the endpoint without authentication, but it will grant to your IP only 10000 requests / hour.
Definitely yes I can understand. For the moment we don't have such a list, but I'll talk with my team to figure out how we can add the feature.
IIUC the token from Meta shouldn't last 4 hours, it doesn't have an expiry IIRC, but we'd need to verify. I completely understand about the complexity of the code, but once you have your token it should just be a matter of setting the bearer auth header and that's it. All steps are indicated in https://wikitech.wikimedia.org/wiki/Machine_Learning/LiftWing/Usage, but if anything doesn't work as expected let us know and we'll try to fix it. It would mean a lot to us to have new clients migrated, so we can understand what's missing, thanks in advance for the patience! |
"Common" (not only for owner and not identity only) Bearer token from Meta expires after 14400 s (4 h). UPD: owner-only oauth2.0 token is indefinite. |
I admit my ignorance about Meta's tokens, reading https://meta.wikimedia.org/wiki/Special:OAuthConsumerRegistration/propose/oauth2 it seemed to me that we issued only OAuth 2.0 tokens, but I see the "Consumer version" set to 1.0. The API Gateway should support both, since we already tested one that doesn't expire. |
Done.
2-4k requests at peak time.
|
To keep archives happy, I created: https://phabricator.wikimedia.org/T340812 Thanks a lot for the report :) |
Some updates:
|
@SiarheiGribov hi! Not sure if you changed or not the calls to the Revert Risk models as explained in [https://meta.wikimedia.org/wiki/Machine_learning_models/Proposed/Language-agnostic_revert_risk#Ethical_considerations,_caveats,_and_recommendations](this link), if so did you notice less errors than with multi-lingual? |
@SiarheiGribov Hi! I think that we can close, what do you think? Anything missing? |
Hi! I am part of the Wikimedia ML team, we are starting the migration of ORES client to another infrastructure, since we are planning to deprecate it. More info in https://wikitech.wikimedia.org/wiki/ORES
TL;DR:
Thanks in advance,
ML team
The text was updated successfully, but these errors were encountered: